Skip to content

docs: 하드코딩 된 contributors 배지 제거 #547 #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

yuiseo
Copy link
Member

@yuiseo yuiseo commented Jul 29, 2024

Related issue

#547

Result

image

Work list

image

Discussion

23명의 contributors로 하드코딩 된 배지를
#547 영택님의 피드백을 반영하여
contributors 배지를 제거합니다.

이슈번호 githru#547 영택님의 피드백을 반영하여 중복 정보인 contributors의 배지를 제거합니다.
@yuiseo yuiseo added the docs label Jul 29, 2024
@yuiseo yuiseo self-assigned this Jul 29, 2024
@yuiseo yuiseo requested review from a team as code owners July 29, 2024 15:02
Copy link
Contributor

@xxxjinn xxxjinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

Copy link
Contributor

@lxxmnmn lxxmnmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 👍👍

@BeA-Pro
Copy link
Contributor

BeA-Pro commented Jul 30, 2024

👍👍

Copy link
Contributor

@ytaek ytaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍👍👍👍👍 LGGTM 입니다!

@ytaek
Copy link
Contributor

ytaek commented Jul 30, 2024

참고로 pr 마지막에

closes #547
요렇게 달면 해당 PR close될때 issue도 같이 close 됩니다!

(찾아보시면 저런 word 시리즈가 있습니다 ㅎ)

@yuiseo yuiseo merged commit d0f936c into githru:main Jul 30, 2024
2 checks passed
@kimdaeyeobbb
Copy link
Contributor

👍👍👍 SGTM

@ytaek ytaek added this to the v0.7.0 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants